linux-kernel - Re: [PATCH 06/10] ipmi: kcs_bmc: Integrate buffers into driver struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7318575f6a5715c4c77ff56e616dfde7877e101a.camel@codeconstruct.com.au>
Date:   Mon, 06 Nov 2023 09:25:55 +1030
From:   Andrew Jeffery <andrew@...econstruct.com.au>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc:     minyard@....org, openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, aladyshev22@...il.com,
        jk@...econstruct.com.au
Subject: Re: [PATCH 06/10] ipmi: kcs_bmc: Integrate buffers into driver
 struct

On Fri, 2023-11-03 at 14:45 +0000, Jonathan Cameron wrote:
> On Fri,  3 Nov 2023 16:45:18 +1030
> Andrew Jeffery <andrew@...econstruct.com.au> wrote:
> 
> > Consolidate several necessary allocations into one to reduce the number
> > of possible error paths.
> > 
> > Signed-off-by: Andrew Jeffery <andrew@...econstruct.com.au>
> Gets rid of some of the devm_kfree() fun, so I'm in favor of the change :)
> 
> One trivial comment inline.
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Thanks.

> > @@ -478,19 +476,15 @@ static int kcs_bmc_ipmi_add_device(struct kcs_bmc_device *kcs_bmc)
> >  
> >  	spin_lock_init(&priv->lock);
> >  	mutex_init(&priv->mutex);
> > -
> Unrelated change...

Ack, will drop in v2.