linux-kernel - Re: [PATCH 04/10] ipmi: kcs_bmc: Make remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61daa1c69836caffd63e3c2d9bb2e62298f1a04a.camel@codeconstruct.com.au>
Date:   Mon, 06 Nov 2023 09:24:10 +1030
From:   Andrew Jeffery <andrew@...econstruct.com.au>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc:     minyard@....org, openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, aladyshev22@...il.com,
        jk@...econstruct.com.au
Subject: Re: [PATCH 04/10] ipmi: kcs_bmc: Make remove_device() callback
 return void

On Fri, 2023-11-03 at 14:43 +0000, Jonathan Cameron wrote:
> On Fri,  3 Nov 2023 16:45:16 +1030
> Andrew Jeffery <andrew@...econstruct.com.au> wrote:
> 
> > Don't pretend there's a valid failure path when there's not.
> > 
> > Signed-off-by: Andrew Jeffery <andrew@...econstruct.com.au>
> 
> Whilst I agree returning an error code is pointless, it is perhaps
> useful to make sure there is a dev_err() or similar in the paths
> now that you've remove the one at the call site.
> 
> Minor point and up to you if you want to or not.

No, that's reasonable. I'll address this in v2.

Andrew