linux-kernel - RE: [PATCH v2 00/13] Introduce support for multiqueue (MQ) in fnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5896BC6839CEDCAD97ACDA7BC3AAA@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date:   Mon, 6 Nov 2023 19:44:35 +0000
From:   "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To:     John Garry <john.g.garry@...cle.com>,
        "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>
CC:     "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>,
        "Dhanraj Jhawar (djhawar)" <djhawar@...co.com>,
        "Gian Carlo Boffa (gcboffa)" <gcboffa@...co.com>,
        "Masa Kai (mkai2)" <mkai2@...co.com>,
        "Satish Kharat (satishkh)" <satishkh@...co.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 00/13] Introduce support for multiqueue (MQ) in fnic

On Thursday, November 2, 2023 2:00 AM, John Garry <john.g.garry@...cle.com> wrote:
>
> On 27/10/2023 19:02, Karan Tilak Kumar wrote:
> > The number of IO queues to be used is stored in a configuration file
> > by the VIC firmware. The fNIC driver reads the configuration file and sets
> > the number of queues to be used. Previously, the driver was hard-coded
> > to use only one queue.
>
> In looking at commit aec95e3a8ded ("scsi: fnic: Refactor code in fnic
> probe to initialize SCSI layer"), support to set shost->nr_hw_queues > 1
> to enable MQ seems to have sneaked in already - what's going on there?
>
> John

Thanks for your review comments, John.
This was a defensive check and code to show that fnic does not have support for MQ 
when the user tries to configure multiple IO queues.
The support for MQ is being added only now.

Regards,
Karan