linux-kernel - RE: [PATCH v2 01/13] scsi: fnic: Modify definitions to sync with VIC firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58968AEAA66C34D2E67F97B9C3AAA@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date:   Mon, 6 Nov 2023 19:47:35 +0000
From:   "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To:     Hannes Reinecke <hare@...e.de>,
        "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>
CC:     "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>,
        "Dhanraj Jhawar (djhawar)" <djhawar@...co.com>,
        "Gian Carlo Boffa (gcboffa)" <gcboffa@...co.com>,
        "Masa Kai (mkai2)" <mkai2@...co.com>,
        "Satish Kharat (satishkh)" <satishkh@...co.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 01/13] scsi: fnic: Modify definitions to sync with VIC
 firmware

On Thursday, November 2, 2023 12:24 AM, Hannes Reinecke <hare@...e.de> wrote:
>
>I would have thought that you may want to check for the firmware version here; updating some limits with no check for the version will mean the driver might fail on older firmware, no?
>
>But this is arguably not part of this patch, so:
>
>Reviewed-by: Hannes Reinecke <hare@...e.de>
>

Thanks for your review and review comments, Hannes. 
Support for these limits has been in firmware for a long time. We are adding support in driver only now.

Regards,
Karan