linux-kernel - Re: [PATCH] regmap: add regmap_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Nov 2023 16:54:37 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Brandon Cheo Fusi <fusibrandon13@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: add regmap_update_bits variant to autoshift mask

On Mon, Nov 06, 2023 at 05:34:06PM +0100, Brandon Cheo Fusi wrote:

> +static inline int regmap_update_bits_autoshift_val(struct regmap *map, unsigned int reg,
> +				     unsigned int mask, unsigned int val)
> +{

Really not a fan of the name here, and in any case if the shifting of
the value is an issue wouldn't this be a good case for using a field?

Please also add kunit testcases for new APIs.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)