linux-kernel - Re: [PATCH v2 1/2] arm64: Move Mediatek GIC quirk handling from irqchip to core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2e7762bfd16f67bdc253dc23a967c46@kernel.org>
Date:   Tue, 07 Nov 2023 17:42:58 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Chen-Yu Tsai <wenst@...omium.org>,
        Amit Daniel Kachhap <amit.kachhap@....com>,
        James Morse <james.morse@....com>,
        Joey Gouly <joey.gouly@....com>,
        Mark Brown <broonie@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] arm64: Move Mediatek GIC quirk handling from
 irqchip to core

On 2023-11-07 17:37, Doug Anderson wrote:
> Hi,
> 
> On Tue, Nov 7, 2023 at 8:30 AM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com> wrote:
>> 
>> > +static __init void detect_system_supports_pseudo_nmi(void)
>> > +{
>> > +     struct device_node *np;
>> > +
>> > +     if (!enable_pseudo_nmi)
>> > +             return;
>> > +
>> > +     /*
>> > +      * Detect broken Mediatek firmware that doesn't properly save and
>> 
>> s/Mediatek/MediaTek/g
>> 
>> Apart from that,
>> 
>> Reviewed-by: AngeloGioacchino Del Regno 
>> <angelogioacchino.delregno@...labora.com>
>> 
>> On MT8195, MT8192, MT8186:
>> Tested-by: AngeloGioacchino Del Regno 
>> <angelogioacchino.delregno@...labora.com>
> 
> Thanks! Unless someone wants me to spin it more quickly, I'll plan to
> send a V3 with the Mediatek=>MediaTek change tomorrow.

I really don't think that's worth the effort.

Catalin can fix this when applying the patch, and even then,
nobody is going to notice that sort of pretty irrelevant
detail.

         M.
-- 
Jazz is not dead. It just smells funny...