[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SJ1PR11MB608345F0C62627E7A0520449FCA9A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Tue, 7 Nov 2023 22:28:27 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: Avadhut Naik <avadhut.naik@....com>,
"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
CC: "rafael@...nel.org" <rafael@...nel.org>,
"lenb@...nel.org" <lenb@...nel.org>,
"james.morse@....com" <james.morse@....com>,
"bp@...en8.de" <bp@...en8.de>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"alexey.kardashevskiy@....com" <alexey.kardashevskiy@....com>,
"yazen.ghannam@....com" <yazen.ghannam@....com>,
"avadnaik@....com" <avadnaik@....com>
Subject: RE: [RESEND v5 2/4] fs: debugfs: Add write functionality to debugfs
blobs
> @@ -1042,7 +1060,7 @@ struct dentry *debugfs_create_blob(const char *name, umode_t mode,
> struct dentry *parent,
> struct debugfs_blob_wrapper *blob)
> {
> - return debugfs_create_file_unsafe(name, mode & 0444, parent, blob, &fops_blob);
> + return debugfs_create_file_unsafe(name, mode, parent, blob, &fops_blob);
> }
The minimalist change here would be to s/0444/0666/
That would just allow callers to ask for writeable files without letting them
add execute permission, or exotic modes like setuid etc.
-Tony
Powered by blists - more mailing lists