[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SJ1PR11MB60835765F536429966023B01FCA9A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Tue, 7 Nov 2023 22:35:05 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: Avadhut Naik <avadhut.naik@....com>,
"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
CC: "rafael@...nel.org" <rafael@...nel.org>,
"lenb@...nel.org" <lenb@...nel.org>,
"james.morse@....com" <james.morse@....com>,
"bp@...en8.de" <bp@...en8.de>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"alexey.kardashevskiy@....com" <alexey.kardashevskiy@....com>,
"yazen.ghannam@....com" <yazen.ghannam@....com>,
"avadnaik@....com" <avadnaik@....com>
Subject: RE: [RESEND v5 3/4] platform/chrome: cros_ec_debugfs: Fix permissions
for panicinfo
> @@ -454,7 +454,7 @@ static int cros_ec_create_panicinfo(struct cros_ec_debugfs *debug_info)
> debug_info->panicinfo_blob.data = data;
> debug_info->panicinfo_blob.size = ret;
>
> - debugfs_create_blob("panicinfo", S_IFREG | 0444, debug_info->dir,
> + debugfs_create_blob("panicinfo", 0444, debug_info->dir,
> &debug_info->panicinfo_blob);
>
This just looks like a bug that S_IFREG was passed in the "mode" argument.
Your change in part 2 doesn't really affect much here.
debugfs_create_blob()
debugfs_create_file_unsafe()
__debugfs_create_file()
which does:
if (!(mode & S_IFMT))
mode |= S_IFREG;
BUG_ON(!S_ISREG(mode));
So this is a fine cleanup. But your patch description about ensuring that
the file remains read-only isn't accurate. Your change didn't affect the mode
of this file.
-Tony
Powered by blists - more mailing lists