linux-kernel - RE: [RESEND v5 4/4] ACPI: APEI: EINJ: Add support for vendor defined error types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB60835E29BF7A8EFA11E44FB2FCA9A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date:   Tue, 7 Nov 2023 22:41:35 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Avadhut Naik <avadhut.naik@....com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
CC:     "rafael@...nel.org" <rafael@...nel.org>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "james.morse@....com" <james.morse@....com>,
        "bp@...en8.de" <bp@...en8.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alexey.kardashevskiy@....com" <alexey.kardashevskiy@....com>,
        "yazen.ghannam@....com" <yazen.ghannam@....com>,
        "avadnaik@....com" <avadnaik@....com>
Subject: RE: [RESEND v5 4/4] ACPI: APEI: EINJ: Add support for vendor defined
 error types

> Circumvent the issue by computing the physical address of OEM Defined data
> structure and establishing the required mapping with the structure. Create
> a new file "oem_error", if the system supports Vendor-defined errors, to
> export this mapping, through debugfs_create_blob(). Userspace tools can
> then populate their respective OEM Defined structure instances and just
> write to the file as part of injecting Vendor-defined Errors. Similarly,
> the tools can also read from the file if the system firmware provides some
> information through the OEM defined structure after error injection.

Tried it out on an Intel Icelake machine.  Seems like it is doing something
reasonable: I end up with this "oem_error" file:

# ls -l oem_error
-rw-------. 1 root root 0 Nov  7 14:26 oem_error

Which is 24 bytes full of zeroes:

# od -t x1 oem_error
0000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0000020 00 00 00 00 00 00 00 00
0000030

I'm not sure what OEM specific errors are implemented on this machine,
so that's as far as I'm able to test.

So apart from s/0444/0666/ in part 2, and a better commit description for
part 3 you can have a:

Reviewed-by: Tony Luck <tony.luck@...el.com>

-Tony