linux-kernel - Re: [PATCH] ARM: dts: qcom: Add LPG LED device description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f7db00f-aae0-43d9-bd6a-47374a91d546@linaro.org>
Date:   Wed, 8 Nov 2023 11:06:12 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        quic_huliu@...cinc.com
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_fenglinw@...cinc.com,
        quic_uchheda@...cinc.com, kamalw@....qualcomm.com
Subject: Re: [PATCH] ARM: dts: qcom: Add LPG LED device description



On 11/8/23 07:59, Dmitry Baryshkov wrote:
> On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay
> <devnull+quic_huliu.quicinc.com@...nel.org> wrote:
>>
>> From: Hui Liu <quic_huliu@...cinc.com>
>>
>> Add LPG LED device description.
> 
> No. You are not adding "LPG LED device description". You are adding
> definition for three LEDs.
> 
>>
>> Signed-off-by: Hui Liu <quic_huliu@...cinc.com>
>> ---
Aside from Dmitry's valid comments, the subject is wrong.

ARM points to arch/arm/ (arm32) and you're missing the name of
the file that you're modifying. Check the git log for that file
to get a grasp of it.

Konrad