linux-kernel - Re: [PATCH] ARM: dts: qcom: Add LPG LED device description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b27add9-ba04-49b0-af60-a191866f9a40@quicinc.com>
Date:   Fri, 10 Nov 2023 09:55:15 +0800
From:   hui liu <quic_huliu@...cinc.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_fenglinw@...cinc.com>,
        <quic_uchheda@...cinc.com>, <kamalw@....qualcomm.com>
Subject: Re: [PATCH] ARM: dts: qcom: Add LPG LED device description



On 11/8/2023 2:59 PM, Dmitry Baryshkov wrote:
> On Wed, 8 Nov 2023 at 08:05, Hui Liu via B4 Relay
> <devnull+quic_huliu.quicinc.com@...nel.org> wrote:
>>
>> From: Hui Liu <quic_huliu@...cinc.com>
>>
>> Add LPG LED device description.
> 
> No. You are not adding "LPG LED device description". You are adding
> definition for three LEDs.
OK, I will update the commit in next patch.

> 
>>
>> Signed-off-by: Hui Liu <quic_huliu@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/pm8350c.dtsi | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> index f28e71487d5c..11b9f384d99c 100644
>> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> @@ -4,6 +4,7 @@
>>    */
>>
>>   #include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/leds/common.h>
>>   #include <dt-bindings/spmi/spmi.h>
>>
>>   &spmi_bus {
>> @@ -34,6 +35,27 @@ pm8350c_pwm: pwm {
>>                          compatible = "qcom,pm8350c-pwm";
>>                          #pwm-cells = <2>;
>>                          status = "disabled";
>> +
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +
>> +                       led@1 {
>> +                               reg = <1>;
>> +                               color = <LED_COLOR_ID_RED>;
>> +                               label = "red";
>> +                       };
>> +
>> +                       led@2 {
>> +                               reg = <2>;
>> +                               color = <LED_COLOR_ID_GREEN>;
>> +                               label = "green";
>> +                       };
>> +
>> +                       led@3 {
>> +                               reg = <3>;
>> +                               color = <LED_COLOR_ID_BLUE>;
>> +                               label = "blue";
> 
> ... and these particular LEDs are board-specific. Please fill them in
> the board file instead.

Sure, I will add these node in board file.
> 
>> +                       };
>>                  };
>>          };
>>   };
>>
>> ---
>> base-commit: b9604be241587fb29c0f40450e53d0a37dc611b5
>> change-id: 20231108-qcom_leds-c3b0b7029008
>>
>> Best regards,
>> --
>> Hui Liu <quic_huliu@...cinc.com>
>>
>>
> 
>