| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <02bb01da1337$65caf5e0$3160e1a0$@samsung.com>
Date: Thu, 9 Nov 2023 23:35:54 +0530
From: "Alim Akhtar" <alim.akhtar@...sung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
"'David Airlie'" <airlied@...il.com>,
"'Daniel Vetter'" <daniel@...ll.ch>,
"'Maarten Lankhorst'" <maarten.lankhorst@...ux.intel.com>,
"'Maxime Ripard'" <mripard@...nel.org>,
"'Thomas Zimmermann'" <tzimmermann@...e.de>,
"'Rob Herring'" <robh+dt@...nel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@...aro.org>,
"'Conor Dooley'" <conor+dt@...nel.org>,
"'Andi Shyti'" <andi.shyti@...nel.org>,
"'Jonathan Cameron'" <jic23@...nel.org>,
"'Lars-Peter Clausen'" <lars@...afoo.de>,
"'Lee Jones'" <lee@...nel.org>,
"'Ulf Hansson'" <ulf.hansson@...aro.org>,
"'Tomasz Figa'" <tomasz.figa@...il.com>,
"'Sylwester Nawrocki'" <s.nawrocki@...sung.com>,
"'Linus Walleij'" <linus.walleij@...aro.org>,
"'Thierry Reding'" <thierry.reding@...il.com>,
'Uwe Kleine-König'
<u.kleine-koenig@...gutronix.de>,
"'Alessandro Zummo'" <a.zummo@...ertech.it>,
"'Alexandre Belloni'" <alexandre.belloni@...tlin.com>,
"'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
"'Jiri Slaby'" <jirislaby@...nel.org>,
"'Liam Girdwood'" <lgirdwood@...il.com>,
"'Mark Brown'" <broonie@...nel.org>,
"'Jaehoon Chung'" <jh80.chung@...sung.com>,
"'Sam Protsenko'" <semen.protsenko@...aro.org>,
<dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-samsung-soc@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
<linux-iio@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
<linux-gpio@...r.kernel.org>, <linux-pwm@...r.kernel.org>,
<linux-rtc@...r.kernel.org>, <linux-serial@...r.kernel.org>,
<alsa-devel@...a-project.org>, <linux-sound@...r.kernel.org>
Subject: RE: [PATCH 02/17] dt-bindings: i2c: exynos5: add specific
compatibles for existing SoC
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, November 8, 2023 4:13 PM
> To: David Airlie <airlied@...il.com>; Daniel Vetter <daniel@...ll.ch>;
> Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>; Maxime Ripard
> <mripard@...nel.org>; Thomas Zimmermann <tzimmermann@...e.de>;
> Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley
> <conor+dt@...nel.org>; Alim Akhtar <alim.akhtar@...sung.com>; Andi
> Shyti <andi.shyti@...nel.org>; Jonathan Cameron <jic23@...nel.org>; Lars-
> Peter Clausen <lars@...afoo.de>; Lee Jones <lee@...nel.org>; Ulf
> Hansson <ulf.hansson@...aro.org>; Tomasz Figa <tomasz.figa@...il.com>;
> Sylwester Nawrocki <s.nawrocki@...sung.com>; Linus Walleij
> <linus.walleij@...aro.org>; Thierry Reding <thierry.reding@...il.com>; Uwe
> Kleine-König <u.kleine-koenig@...gutronix.de>; Alessandro Zummo
> <a.zummo@...ertech.it>; Alexandre Belloni
> <alexandre.belloni@...tlin.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Jiri Slaby <jirislaby@...nel.org>; Liam
> Girdwood <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>;
> Jaehoon Chung <jh80.chung@...sung.com>; Sam Protsenko
> <semen.protsenko@...aro.org>; dri-devel@...ts.freedesktop.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org; linux-
> i2c@...r.kernel.org; linux-iio@...r.kernel.org; linux-mmc@...r.kernel.org;
> linux-gpio@...r.kernel.org; linux-pwm@...r.kernel.org; linux-
> rtc@...r.kernel.org; linux-serial@...r.kernel.org; alsa-devel@...a-
> project.org; linux-sound@...r.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Subject: [PATCH 02/17] dt-bindings: i2c: exynos5: add specific compatibles for
> existing SoC
>
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only. This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> ---
>
> I propose to take the patch through Samsung SoC (me). See cover letter for
> explanation.
> ---
> Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++++++++-
> .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 2 +-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> index 3e52a0db6c41..c1f5d2cb7709 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> @@ -25,7 +25,15 @@ properties:
> - samsung,exynos5250-hsi2c # Exynos5250 and Exynos5420
> - samsung,exynos5260-hsi2c # Exynos5260
> - samsung,exynos7-hsi2c # Exynos7
> - - samsung,exynosautov9-hsi2c # ExynosAutoV9 and Exynos850
> + - samsung,exynosautov9-hsi2c
> + - items:
> + - enum:
> + - samsung,exynos5433-hsi2c
> + - const: samsung,exynos7-hsi2c
> + - items:
> + - enum:
> + - samsung,exynos850-hsi2c
Does this need an entry in allOf:? to indicate exynos850 also has 2 clocks?
> + - const: samsung,exynosautov9-hsi2c
> - const: samsung,exynos5-hsi2c # Exynos5250 and Exynos5420
> deprecated: true
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-
> usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-
> usi.yaml
> index a6836904a4f8..5b7ab69546c4 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> @@ -155,7 +155,7 @@ examples:
> };
>
> hsi2c_0: i2c@...20000 {
> - compatible = "samsung,exynosautov9-hsi2c";
> + compatible = "samsung,exynos850-hsi2c",
> + "samsung,exynosautov9-hsi2c";
> reg = <0x13820000 0xc0>;
> interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <1>;
> --
> 2.34.1
Powered by blists - more mailing lists