lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <029f01da1335$7c8ed1e0$75ac75a0$@samsung.com>
Date:   Thu, 9 Nov 2023 23:22:14 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        "'David Airlie'" <airlied@...il.com>,
        "'Daniel Vetter'" <daniel@...ll.ch>,
        "'Maarten Lankhorst'" <maarten.lankhorst@...ux.intel.com>,
        "'Maxime Ripard'" <mripard@...nel.org>,
        "'Thomas Zimmermann'" <tzimmermann@...e.de>,
        "'Rob Herring'" <robh+dt@...nel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@...aro.org>,
        "'Conor Dooley'" <conor+dt@...nel.org>,
        "'Andi Shyti'" <andi.shyti@...nel.org>,
        "'Jonathan Cameron'" <jic23@...nel.org>,
        "'Lars-Peter Clausen'" <lars@...afoo.de>,
        "'Lee Jones'" <lee@...nel.org>,
        "'Ulf Hansson'" <ulf.hansson@...aro.org>,
        "'Tomasz Figa'" <tomasz.figa@...il.com>,
        "'Sylwester Nawrocki'" <s.nawrocki@...sung.com>,
        "'Linus Walleij'" <linus.walleij@...aro.org>,
        "'Thierry Reding'" <thierry.reding@...il.com>,
        'Uwe Kleine-König' 
        <u.kleine-koenig@...gutronix.de>,
        "'Alessandro Zummo'" <a.zummo@...ertech.it>,
        "'Alexandre Belloni'" <alexandre.belloni@...tlin.com>,
        "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
        "'Jiri Slaby'" <jirislaby@...nel.org>,
        "'Liam Girdwood'" <lgirdwood@...il.com>,
        "'Mark Brown'" <broonie@...nel.org>,
        "'Jaehoon Chung'" <jh80.chung@...sung.com>,
        "'Sam Protsenko'" <semen.protsenko@...aro.org>,
        <dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        <linux-iio@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <linux-pwm@...r.kernel.org>,
        <linux-rtc@...r.kernel.org>, <linux-serial@...r.kernel.org>,
        <alsa-devel@...a-project.org>, <linux-sound@...r.kernel.org>
Subject: RE: [PATCH 01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add
 specific compatibles for existing SoC



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, November 8, 2023 4:13 PM
> To: David Airlie <airlied@...il.com>; Daniel Vetter <daniel@...ll.ch>;
> Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>; Maxime Ripard
> <mripard@...nel.org>; Thomas Zimmermann <tzimmermann@...e.de>;
> Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley
> <conor+dt@...nel.org>; Alim Akhtar <alim.akhtar@...sung.com>; Andi
> Shyti <andi.shyti@...nel.org>; Jonathan Cameron <jic23@...nel.org>; Lars-
> Peter Clausen <lars@...afoo.de>; Lee Jones <lee@...nel.org>; Ulf
> Hansson <ulf.hansson@...aro.org>; Tomasz Figa <tomasz.figa@...il.com>;
> Sylwester Nawrocki <s.nawrocki@...sung.com>; Linus Walleij
> <linus.walleij@...aro.org>; Thierry Reding <thierry.reding@...il.com>; Uwe
> Kleine-König <u.kleine-koenig@...gutronix.de>; Alessandro Zummo
> <a.zummo@...ertech.it>; Alexandre Belloni
> <alexandre.belloni@...tlin.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Jiri Slaby <jirislaby@...nel.org>; Liam
> Girdwood <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>;
> Jaehoon Chung <jh80.chung@...sung.com>; Sam Protsenko
> <semen.protsenko@...aro.org>; dri-devel@...ts.freedesktop.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org; linux-
> i2c@...r.kernel.org; linux-iio@...r.kernel.org; linux-mmc@...r.kernel.org;
> linux-gpio@...r.kernel.org; linux-pwm@...r.kernel.org; linux-
> rtc@...r.kernel.org; linux-serial@...r.kernel.org; alsa-devel@...a-
> project.org; linux-sound@...r.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Subject: [PATCH 01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add
> specific compatibles for existing SoC
> 
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only.  This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
> 
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

> ---
> 
> I propose to take the patch through Samsung SoC (me). See cover letter for
> explanation.
> ---
>  .../bindings/hwinfo/samsung,exynos-chipid.yaml  | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-
> chipid.yaml
> b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> index 95cbdcb56efe..45f3d468db7c 100644
> --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-
> chipid.yaml
> +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-
> chipid.yam
> +++ l
> @@ -11,9 +11,20 @@ maintainers:
> 
>  properties:
>    compatible:
> -    enum:
> -      - samsung,exynos4210-chipid
> -      - samsung,exynos850-chipid
> +    oneOf:
> +      - enum:
> +          - samsung,exynos4210-chipid
> +          - samsung,exynos850-chipid
> +      - items:
> +          - enum:
> +              - samsung,exynos5433-chipid
> +              - samsung,exynos7-chipid
> +          - const: samsung,exynos4210-chipid
> +      - items:
> +          - enum:
> +              - samsung,exynos7885-chipid
> +              - samsung,exynosautov9-chipid
> +          - const: samsung,exynos850-chipid
> 
>    reg:
>      maxItems: 1
> --
> 2.34.1



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ