linux-kernel - Re: [PATCH V5 2/8] perf/x86: Add PERF_X86_EVENT_NEEDS_BRANCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2023 15:46:50 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     "Liang, Kan" <kan.liang@...ux.intel.com>
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        namhyung@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
        ak@...ux.intel.com, eranian@...gle.com,
        alexey.v.bayduraev@...ux.intel.com, tinghao.zhang@...el.com
Subject: Re: [PATCH V5 2/8] perf/x86: Add PERF_X86_EVENT_NEEDS_BRANCH_STACK
 flag

Em Thu, Nov 09, 2023 at 12:05:27PM -0500, Liang, Kan escreveu:
> On 2023-11-09 11:45 a.m., Arnaldo Carvalho de Melo wrote:
> > Em Thu, Nov 09, 2023 at 11:14:31AM -0500, Liang, Kan escreveu:
> >> The below change should fix it. I will post a complete patch shortly.

> > Thanks for the quick response, if all that is needed are the checks
> > below, I'll fold it into your original patch:

> > 2ae01908298426e4 perf tools: Add branch counter knob

> > So that we don't regress, ok?

> Sure.

> I also post the patch to
> https://lore.kernel.org/lkml/20231109164007.2037721-1-kan.liang@linux.intel.com/
> Either folding it or using the new patch is fine for me.

I folded it, retested, pushed out perf-tools-next.
 
> BTW: the new perf test case for the feature is posted here.
> I think Ian is reviewing it.
> https://lore.kernel.org/lkml/20231107184020.1497571-1-kan.liang@linux.intel.com/

Ok, lets wait some more.

Hey, what is SFR/GRR? Sapphire Rapids/Granite Rapids? I thought about
testing this somehow, if possible.

- Arnaldo