linux-kernel - Re: [PATCH for-next v7 5/7] RDMA/rxe: Allow registering MRs for On-Demand Paging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202311100130.efgRVVKL-lkp@intel.com>
Date:   Fri, 10 Nov 2023 02:49:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daisuke Matsuda <matsuda-daisuke@...itsu.com>,
        linux-rdma@...r.kernel.org, leon@...nel.org, jgg@...pe.ca,
        zyjzyj2000@...il.com
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        rpearsonhpe@...il.com, yangx.jy@...itsu.com, lizhijian@...itsu.com,
        y-goto@...itsu.com, Daisuke Matsuda <matsuda-daisuke@...itsu.com>
Subject: Re: [PATCH for-next v7 5/7] RDMA/rxe: Allow registering MRs for
 On-Demand Paging

Hi Daisuke,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rdma/for-next]
[also build test WARNING on linus/master v6.6 next-20231109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Daisuke-Matsuda/RDMA-rxe-Always-defer-tasks-on-responder-and-completer-to-workqueue/20231109-185612
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
patch link:    https://lore.kernel.org/r/5d46bd682aa8e3d5cabc38ca1cd67d2976f2731d.1699503619.git.matsuda-daisuke%40fujitsu.com
patch subject: [PATCH for-next v7 5/7] RDMA/rxe: Allow registering MRs for On-Demand Paging
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20231110/202311100130.efgRVVKL-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231110/202311100130.efgRVVKL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311100130.efgRVVKL-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/infiniband/sw/rxe/rxe_odp.c: In function 'rxe_mr_set_xarray':
>> drivers/infiniband/sw/rxe/rxe_odp.c:35:22: warning: variable 'entry' set but not used [-Wunused-but-set-variable]
      35 |         void *page, *entry;
         |                      ^~~~~


vim +/entry +35 drivers/infiniband/sw/rxe/rxe_odp.c

    29	
    30	static void rxe_mr_set_xarray(struct rxe_mr *mr, unsigned long start,
    31				      unsigned long end, unsigned long *pfn_list)
    32	{
    33		unsigned long upper = rxe_mr_iova_to_index(mr, end - 1);
    34		unsigned long lower = rxe_mr_iova_to_index(mr, start);
  > 35		void *page, *entry;
    36	
    37		XA_STATE(xas, &mr->page_list, lower);
    38	
    39		xas_lock(&xas);
    40		while (xas.xa_index <= upper) {
    41			if (pfn_list[xas.xa_index] & HMM_PFN_WRITE) {
    42				page = xa_tag_pointer(hmm_pfn_to_page(pfn_list[xas.xa_index]),
    43						      RXE_ODP_WRITABLE_BIT);
    44			} else
    45				page = hmm_pfn_to_page(pfn_list[xas.xa_index]);
    46	
    47			xas_store(&xas, page);
    48			entry = xas_next(&xas);
    49		}
    50		xas_unlock(&xas);
    51	}
    52	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki