linux-kernel - Re: [RFC 6/7] iommufd/selftest: Add test coverage for SIOV virtual device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <110f5a3a-7f3f-4b82-bb12-c7ca5df5c98f@intel.com>
Date:   Thu, 9 Nov 2023 15:48:21 +0800
From:   Yi Liu <yi.l.liu@...el.com>
To:     "Tian, Kevin" <kevin.tian@...el.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "jgg@...dia.com" <jgg@...dia.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>
CC:     "cohuck@...hat.com" <cohuck@...hat.com>,
        "eric.auger@...hat.com" <eric.auger@...hat.com>,
        "nicolinc@...dia.com" <nicolinc@...dia.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "mjrosato@...ux.ibm.com" <mjrosato@...ux.ibm.com>,
        "chao.p.peng@...ux.intel.com" <chao.p.peng@...ux.intel.com>,
        "yi.y.sun@...ux.intel.com" <yi.y.sun@...ux.intel.com>,
        "peterx@...hat.com" <peterx@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "shameerali.kolothum.thodi@...wei.com" 
        <shameerali.kolothum.thodi@...wei.com>,
        "lulu@...hat.com" <lulu@...hat.com>,
        "suravee.suthikulpanit@....com" <suravee.suthikulpanit@....com>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@...el.com>,
        "Martins, Joao" <joao.m.martins@...cle.com>
Subject: Re: [RFC 6/7] iommufd/selftest: Add test coverage for SIOV virtual
 device

On 2023/10/10 16:30, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@...el.com>
>> Sent: Monday, October 9, 2023 4:51 PM
>>
>> @@ -2071,6 +2083,43 @@ TEST_F(iommufd_device_pasid, pasid_attach)
>>
>> IOMMU_HWPT_ALLOC_DATA_SELFTEST,
>>   					   &data, sizeof(data));
>>
>> +		if (variant->pasid) {
>> +			uint32_t new_hwpt_id = 0;
>> +
>> +			ASSERT_EQ(0,
>> +				  test_cmd_pasid_check_domain(self->fd,
>> +							      self->stdev_id,
>> +							      variant->pasid,
>> +							      self->hwpt_id,
>> +							      &result));
>> +			EXPECT_EQ(1, result);
>> +			test_cmd_hwpt_alloc(self->device_id, self->ioas_id,
>> +					    0, &new_hwpt_id);
>> +			test_cmd_mock_domain_replace(self->stdev_id,
>> +						     new_hwpt_id);
>> +			ASSERT_EQ(0,
>> +				  test_cmd_pasid_check_domain(self->fd,
>> +							      self->stdev_id,
>> +							      variant->pasid,
>> +							      new_hwpt_id,
>> +							      &result));
>> +			EXPECT_EQ(1, result);
>> +
>> +			/*
>> +			 * Detach hwpt from variant->pasid, and check if the
>> +			 * variant->pasid has null domain
>> +			 */
>> +			test_cmd_pasid_detach(variant->pasid);
>> +			ASSERT_EQ(0,
>> +				  test_cmd_pasid_check_domain(self->fd,
>> +							      self->stdev_id,
>> +							      variant->pasid,
>> +							      0, &result));
>> +			EXPECT_EQ(1, result);
>> +
>> +			test_ioctl_destroy(new_hwpt_id);
>> +		}
>> +
> 
> I wonder whether above better reuses the device attach/replace cases
> given default_pasid is hidden inside iommufd_device. this pasid_attach
> case is more for testing user pasids on a iommufd_device which hasn't
> yet been supported by SIOV device?

perhaps the way how the above code checks the attached domain misled you.
Actually, this is still testing the siov default_pasid. In the variant
setup, the default_pasid is passed to the testing driver when creating
the stdev. That's why the replace test does not require a pasid.

maybe I can let have a new selftest op to check attached domain for a given 
stdev instead of reusing test_cmd_pasid_check_domain().

-- 
Regards,
Yi Liu