[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231109084110.4056-1-jose.pekkarinen@foxhound.fi>
Date: Thu, 9 Nov 2023 10:41:10 +0200
From: José Pekkarinen <jose.pekkarinen@...hound.fi>
To: evan.quan@....com, alexander.deucher@....com,
christian.koenig@....com, Xinhui.Pan@....com,
skhan@...uxfoundation.org
Cc: José Pekkarinen <jose.pekkarinen@...hound.fi>,
airlied@...il.com, daniel@...ll.ch, jdelvare@...e.com,
linux@...ck-us.net, amd-gfx@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linux-kernel-mentees@...ts.linux.dev
Subject: [PATCH] drm/amd/pm: make power values signed
The following patch will convert the power values returned by
amdgpu_hwmon_get_power to signed, fixing the following warnings reported
by coccinelle:
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2801:5-8: WARNING: Unsigned expression compared with zero: val < 0
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2814:5-8: WARNING: Unsigned expression compared with zero: val < 0
Signed-off-by: José Pekkarinen <jose.pekkarinen@...hound.fi>
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index e7bb1d324084..913ff62d5d5e 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -2795,7 +2795,7 @@ static ssize_t amdgpu_hwmon_show_power_avg(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- unsigned int val;
+ int val;
val = amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_AVG_POWER);
@@ -2806,7 +2806,7 @@ static ssize_t amdgpu_hwmon_show_power_input(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- unsigned int val;
+ int val;
val = amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_INPUT_POWER);
--
2.39.2
Powered by blists - more mailing lists