linux-kernel - Re: [PATCH 4/4] dt-bindings: hwmon: Add Amphenol ChipCap 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b1d6fe8-529b-4cf4-ba0a-697c7aeac174@linaro.org>
Date:   Thu, 9 Nov 2023 09:41:33 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Javier Carrasco <javier.carrasco.cruz@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jonathan Corbet <corbet@....net>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: hwmon: Add Amphenol ChipCap 2

On 08/11/2023 13:44, Javier Carrasco wrote:

>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - amphenol,cc2dxx
>>> +      - amphenol,cc2dxxs
>>
>> What does xx stand for? Wildcard? I do not see cc2dxx in part numbers.
>> We expect specific compatibles, not generic. What are the differences
>> between all parts?
>>
> There are two device families: cc2dxx and cc2dxxs, where xx indicates
> the voltage and the accuracy. That does not change how the devices works
> and it is not relevant for the driver. The 's' indicates that it is a
> sleep device, and that modifies how it works.
> I listed the supported part numbers in the hwmon documentation, where
> they are also divided into these two families.

If the number of devices is relatively small, list them all. Otherwise
choose one device model and use it. No family models. No wildcards.

>>> +


Best regards,
Krzysztof