linux-kernel - Re: [PATCH] wifi: iwlwifi: Fix warning by adding dependency on DMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a5203915a94a0299131d3e03d132c40bd98dee6.camel@sipsolutions.net>
Date:   Thu, 09 Nov 2023 10:09:53 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Sunil V L <sunilvl@...tanamicro.com>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Gregory Greenman <gregory.greenman@...el.com>,
        Kalle Valo <kvalo@...nel.org>,
        Palmer Dabbelt <palmer@...osinc.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Andrew Jones <ajones@...tanamicro.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] wifi: iwlwifi: Fix warning by adding dependency on DMI

On Thu, 2023-11-09 at 11:10 +0530, Sunil V L wrote:
> This driver currently assumes CONFIG_DMI is enabled along with ACPI.
> This may not be true. Due to this, the kernel test bot reports new
> warning like below for RISC-V allyesconfig builds.
> 
> > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1190:25:
> warning: '%s' directive argument is null [-Wformat-overflow=]
> 
> 1190 | "System vendor '%s' is not in the approved list, disabling PPAG.\n",
> 
> Fix the warning by adding dependency on CONFIG_DMI.
> 

Not sure that's the right fix - why not put checks in the code there?

Is it just a build warning?

maybe

-dmi_get_system_info(DMI_SYS_VENDOR)
+dmi_get_system_info(DMI_SYS_VENDOR) ?: "<unknown>"

johannes