[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZUz2nLO28djDYZHJ@sunil-laptop>
Date: Thu, 9 Nov 2023 20:41:24 +0530
From: Sunil V L <sunilvl@...tanamicro.com>
To: Johannes Berg <johannes@...solutions.net>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
Gregory Greenman <gregory.greenman@...el.com>,
Kalle Valo <kvalo@...nel.org>,
Palmer Dabbelt <palmer@...osinc.com>,
Conor Dooley <conor.dooley@...rochip.com>,
Andrew Jones <ajones@...tanamicro.com>,
kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] wifi: iwlwifi: Fix warning by adding dependency on DMI
On Thu, Nov 09, 2023 at 10:09:53AM +0100, Johannes Berg wrote:
> On Thu, 2023-11-09 at 11:10 +0530, Sunil V L wrote:
> > This driver currently assumes CONFIG_DMI is enabled along with ACPI.
> > This may not be true. Due to this, the kernel test bot reports new
> > warning like below for RISC-V allyesconfig builds.
> >
> > > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1190:25:
> > warning: '%s' directive argument is null [-Wformat-overflow=]
> >
> > 1190 | "System vendor '%s' is not in the approved list, disabling PPAG.\n",
> >
> > Fix the warning by adding dependency on CONFIG_DMI.
> >
>
> Not sure that's the right fix - why not put checks in the code there?
>
> Is it just a build warning?
>
> maybe
>
> -dmi_get_system_info(DMI_SYS_VENDOR)
> +dmi_get_system_info(DMI_SYS_VENDOR) ?: "<unknown>"
>
Thanks!, Johannes. It is a build warning because of allyesconfig build.
Your suggestion works. I will send v2 with this solution.
Thanks,
Sunil
Powered by blists - more mailing lists