linux-kernel - Re: [PATCH] serial: uartlite: Use dynamic allocation for major number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023110915-trusting-pointer-40b0@gregkh>
Date:   Thu, 9 Nov 2023 14:20:25 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Manikanta Guntupalli <manikanta.guntupalli@....com>
Cc:     git@....com, michal.simek@....com, jacmet@...site.dk,
        jirislaby@...nel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, radhey.shyam.pandey@....com,
        srinivas.goud@....com, shubhrajyoti.datta@....com,
        manion05gk@...il.com
Subject: Re: [PATCH] serial: uartlite: Use dynamic allocation for major number

On Thu, Nov 09, 2023 at 06:06:40PM +0530, Manikanta Guntupalli wrote:
> Device number 204 has a range of minors on major number.
> uart_register_driver is failing due to lack of minor numbers
> when more number of uart ports used.

So you need more than the 4 allocated to you?

> So, use dynamic allocation
> for major number to avoid minor number limitation on 204 major
> number.
> 
> https://docs.kernel.org/arch/arm/sa1100/serial_uart.html

What does this break by doing this?

Also, you forgot to update the documentation :(

And how was this tested?  What about older systems with static device
nodes, are you sure none are out there for this old hardware anymore?

thanks,

greg k-h