linux-kernel - Re: [PATCH v2] ksmbd: prevent memory leak on error return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd_A-3kfK40hi9rkoKr=AVKG=_kK3_3ABbsuC0c-S6zk+g@mail.gmail.com>
Date:   Thu, 9 Nov 2023 22:21:40 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Zongmin Zhou <min_halo@....com>
Cc:     linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
        senozhatsky@...omium.org, sfrench@...ba.org, tom@...pey.com,
        kernel test robot <lkp@...el.com>,
        Dan Carpenter <error27@...il.com>,
        Zongmin Zhou <zhouzongmin@...inos.cn>
Subject: Re: [PATCH v2] ksmbd: prevent memory leak on error return

2023-11-09 10:17 GMT+09:00, Zongmin Zhou <min_halo@....com>:
> When allocated memory for 'new' failed,just return
> will cause memory leak of 'ar'.
>
> v2: rollback iov_alloc_cnt when allocate memory failed.
>
> Fixes: 1819a9042999 ("ksmbd: reorganize ksmbd_iov_pin_rsp()")
>
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <error27@...il.com>
> Closes: https://lore.kernel.org/r/202311031837.H3yo7JVl-lkp@intel.com/
> Signed-off-by: Zongmin Zhou<zhouzongmin@...inos.cn>
Acked-by: Namjae Jeon <linkinjeon@...nel.org>

Applied it #ksmbd-for-next-next.
Thanks for your patch.