linux-kernel - Re: [PATCH v7 05/24] x86/resctrl: Track the closid with the rmid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4e18e30-1898-471e-8065-ebb85d654084@intel.com>
Date:   Thu, 9 Nov 2023 09:41:29 -0800
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     James Morse <james.morse@....com>, <x86@...nel.org>,
        <linux-kernel@...r.kernel.org>
CC:     Fenghua Yu <fenghua.yu@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        H Peter Anvin <hpa@...or.com>,
        Babu Moger <Babu.Moger@....com>,
        <shameerali.kolothum.thodi@...wei.com>,
        D Scott Phillips OS <scott@...amperecomputing.com>,
        <carl@...amperecomputing.com>, <lcherian@...vell.com>,
        <bobo.shaobowang@...wei.com>, <tan.shaopeng@...itsu.com>,
        <baolin.wang@...ux.alibaba.com>,
        Jamie Iles <quic_jiles@...cinc.com>,
        Xin Hao <xhao@...ux.alibaba.com>, <peternewman@...gle.com>,
        <dfustini@...libre.com>, <amitsinght@...vell.com>
Subject: Re: [PATCH v7 05/24] x86/resctrl: Track the closid with the rmid

Hi James,

On 10/25/2023 11:03 AM, James Morse wrote:
> @@ -732,10 +752,10 @@ static int dom_data_init(struct rdt_resource *r)
>  	}
>  
>  	/*
> -	 * RMID 0 is special and is always allocated. It's used for all
> -	 * tasks that are not monitored.
> -	 */
> -	entry = __rmid_entry(0);
> +	* These are used for rdtgroup_default control group, which will be
> +	* setup later in rdtgroup_init().

This sentence I provided was intended to just replace two sentences, not the
entire paragraph you had. Note that I explicitly stated "change last two
sentences". Without the original text the above "These" is not clear.
If you just want to copy&paste here is the entire intended comment:

	RESCTRL_RESERVED_CLOSID and RESCTRL_RESERVED_RMID are special and
	are always allocated. These are used for the rdtgroup_default
	control group, which will be setup later in rdtgroup_init().

Reinette