linux-kernel - Re: [PATCH v3 2/4] phy: realtek: usb: add new driver for the Realtek RTD SoC USB 2.0 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZU3gHcugq9FxBG4P@hovoldconsulting.com>
Date:   Fri, 10 Nov 2023 08:47:41 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Stanley Chang <stanley_chang@...ltek.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Rob Herring <robh@...nel.org>,
        Jinjie Ruan <ruanjinjie@...wei.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Roy Luo <royluo@...gle.com>,
        Ricardo Cañuelo <ricardo.canuelo@...labora.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Flavio Suligoi <f.suligoi@...m.it>,
        linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v3 2/4] phy: realtek: usb: add new driver for the Realtek
 RTD SoC USB 2.0 PHY

On Fri, Nov 10, 2023 at 01:45:13PM +0800, Stanley Chang wrote:
> Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB
> controller. Added the driver to drive the USB 2.0 PHY transceivers.
> 
> Note: New driver,remove the port status notification on legacy USB PHY.
> Use the generic PHY to notify the usb device connect and disconnect.
> To avoid using these PHYs would require describing the very same
> PHY using both the generic "phy" property and the deprecated "usb-phy"
> property.
> 
> Signed-off-by: Stanley Chang <stanley_chang@...ltek.com>
> ---
> v1 to v2 change:
>     rebase the driver to include the revert part on
>     7a784bcdd7e54f0599da3b2360e472238412623e
> v2 to v3 change:
>     remove MODULE_ALIAS

Don't send out a new version of a patch series immediately just to fix
something small like this.

In this case I'd suggest you wait at least until you've gotten feedback
on the new notification implementation.

Johan