lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231110150304.hvcrpc2g6badys5v@revolver>
Date:   Fri, 10 Nov 2023 10:03:04 -0500
From:   "Liam R. Howlett" <Liam.Howlett@...cle.com>
To:     Levi Yun <ppbuk5246@...il.com>
Cc:     maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] maple_tree: change return type of mas_split_final_node
 as void.

* Levi Yun <ppbuk5246@...il.com> [231109 11:18]:
> mas_split_final_node always returns true and there is no usage
> for checking return value.
> 
> change return type as void.

Thanks for the patch.

> 
> Signed-off-by: Levi Yun <ppbuk5246@...il.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> ---
>  lib/maple_tree.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index bb24d84a4922..9389a631483a 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -3167,7 +3167,7 @@ static inline void mas_destroy_rebalance(struct ma_state *mas, unsigned char end
>   * @mas: The maple state
>   * @height: The height of the tree in case it's a new root.
>   */
> -static inline bool mas_split_final_node(struct maple_subtree_state *mast,
> +static inline void mas_split_final_node(struct maple_subtree_state *mast,
>  					struct ma_state *mas, int height)
>  {
>  	struct maple_enode *ancestor;
> @@ -3191,7 +3191,6 @@ static inline bool mas_split_final_node(struct maple_subtree_state *mast,
>  	mast->l->node = ancestor;
>  	mab_mas_cp(mast->bn, 0, mt_slots[mast->bn->type] - 1, mast->l, true);
>  	mas->offset = mast->bn->b_end - 1;
> -	return true;
>  }
> 
>  /*
> --
> 2.39.2

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ