linux-kernel - Re: [PATCH 17/22] powerpc: ps3: move udbg_shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5e0966cd-7fa6-4217-a92e-d4a73b6b8bd6@app.fastmail.com>
Date:   Fri, 10 Nov 2023 07:30:20 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Michael Ellerman" <mpe@...erman.id.au>,
        "kernel test robot" <lkp@...el.com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        "Masahiro Yamada" <masahiroy@...nel.org>,
        linux-kbuild@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        "Linux Memory Management List" <linux-mm@...ck.org>,
        "Matt Turner" <mattst88@...il.com>,
        "Vineet Gupta" <vgupta@...nel.org>,
        "Russell King" <linux@...linux.org.uk>,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Will Deacon" <will@...nel.org>,
        "Steven Rostedt" <rostedt@...dmis.org>,
        "Masami Hiramatsu" <mhiramat@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>, guoren <guoren@...nel.org>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "Ard Biesheuvel" <ardb@...nel.org>,
        "Huacai Chen" <chenhuacai@...nel.org>,
        "Greg Ungerer" <gerg@...ux-m68k.org>,
        "Michal Simek" <monstr@...str.eu>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "Dinh Nguyen" <dinguyen@...nel.org>,
        "Nicholas Piggin" <npiggin@...il.com>,
        "Christophe Leroy" <christophe.leroy@...roup.eu>,
        "Geoff Levand" <geoff@...radead.org>,
        "Palmer Dabbelt" <palmer@...belt.com>,
        "Heiko Carstens" <hca@...ux.ibm.com>,
        "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
        "Andy Lutomirski" <luto@...nel.org>
Subject: Re: [PATCH 17/22] powerpc: ps3: move udbg_shutdown_ps3gelic prototype

On Fri, Nov 10, 2023, at 04:40, Michael Ellerman wrote:

> As pointed out by Arnd this is due to there being two symbols that
> control the gelic_udbg.c code.
>
> I don't see the need for PS3GELIC_UDBG, without PPC_EARLY_DEBUG_PS3GELIC
> it just causes gelic_udbg.c to be built, but never called.
>
> The diff below fixes the error AFAICS.
>
> I can just fold it in if you're happy with that Arnd.

Yes, looks good to me, please do.

    Arnd