linux-kernel - Re: [PATCH 21/22] fbdev/fsl-diu-fb: mark wr_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0890b48-d630-4179-89a2-86bb953ae2bf@gmx.de>
Date:   Fri, 10 Nov 2023 08:06:28 +0100
From:   Helge Deller <deller@....de>
To:     Arnd Bergmann <arnd@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/22] fbdev/fsl-diu-fb: mark wr_reg_wa() static

On 11/8/23 13:58, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> wr_reg_wa() is not an appropriate name for a global function, and doesn't need
> to be global anyway, so mark it static and avoid the warning:
>
> drivers/video/fbdev/fsl-diu-fb.c:493:6: error: no previous prototype for 'wr_reg_wa' [-Werror=missing-prototypes]
>
> Fixes: 0d9dab39fbbe ("powerpc/5121: fsl-diu-fb: fix issue with re-enabling DIU area descriptor")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

applied this patch to the fbdev git tree.

Thanks!
Helge


> ---
>   drivers/video/fbdev/fsl-diu-fb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
> index 7fbd9f069ac2..0bced82fa494 100644
> --- a/drivers/video/fbdev/fsl-diu-fb.c
> +++ b/drivers/video/fbdev/fsl-diu-fb.c
> @@ -490,7 +490,7 @@ static enum fsl_diu_monitor_port fsl_diu_name_to_port(const char *s)
>    * Workaround for failed writing desc register of planes.
>    * Needed with MPC5121 DIU rev 2.0 silicon.
>    */
> -void wr_reg_wa(u32 *reg, u32 val)
> +static void wr_reg_wa(u32 *reg, u32 val)
>   {
>   	do {
>   		out_be32(reg, val);