linux-kernel - Re: [PATCH 05/22] [RESEND] parport: gsc: mark init function static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c030e573-b350-4da3-9fc6-f62a00a53a25@gmx.de>
Date:   Fri, 10 Nov 2023 08:47:28 +0100
From:   Helge Deller <deller@....de>
To:     Arnd Bergmann <arnd@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/22] [RESEND] parport: gsc: mark init function static

On 11/8/23 13:58, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> This is only used locally, so mark it static to avoid a warning:
>
> drivers/parport/parport_gsc.c:395:5: error: no previous prototype for 'parport_gsc_init' [-Werror=missing-prototypes]
>
> Acked-by: Helge Deller <deller@....de>
> Acked-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Since the parport_gsc driver is only used on parisc machines,
I've added this patch to the parisc git tree.

Thanks!
Helge


> ---
>   drivers/parport/parport_gsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parport/parport_gsc.c b/drivers/parport/parport_gsc.c
> index 5e4475254bd0..c7e18382dc01 100644
> --- a/drivers/parport/parport_gsc.c
> +++ b/drivers/parport/parport_gsc.c
> @@ -392,7 +392,7 @@ static struct parisc_driver parport_driver __refdata = {
>   	.remove		= __exit_p(parport_remove_chip),
>   };
>
> -int parport_gsc_init(void)
> +static int parport_gsc_init(void)
>   {
>   	return register_parisc_driver(&parport_driver);
>   }