linux-kernel - Re: [PATCH] mm/damon/core.c: avoid unintentional filtering out of schemes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231110103122.21d5fb5f3d60f1f4f5bd143f@linux-foundation.org>
Date:   Fri, 10 Nov 2023 10:31:22 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     SeongJae Park <sj@...nel.org>
Cc:     Hyeongtak Ji <hyeongtak.ji@...il.com>, damon@...ts.linux.dev,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Hyeongtak Ji <hyeongtak.ji@...com>
Subject: Re: [PATCH] mm/damon/core.c: avoid unintentional filtering out of
 schemes

On Fri, 10 Nov 2023 18:22:40 +0000 SeongJae Park <sj@...nel.org> wrote:

> Hello Hyueongtak,
> 
> On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji <hyeongtak.ji@...il.com> wrote:
> 
> > The function '__damos_filter_out()' causes DAMON to always filter out
> > schemes whose filter type is anon or memcg if its matching value is set
> > to false.
> > 
> > This commit addresses the issue by ensuring that '__damos_filter_out()'
> > no longer applies to filters whose type is 'anon' or 'memcg'.
> 
> Nice catch, thank you!
> 
> checkpatch.pl shows one warning, though:
> 
>     WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji <hyeongtak.ji@...il.com>' != 'Signed-off-by: Hyeongtak Ji <hyeongtak.ji@...com>'

This can be addressed by including an explicit From: line at start of
changelog.  Which should we use?

> > 
> > Signed-off-by: Hyeongtak Ji <hyeongtak.ji@...com>
> 
> Reviewed-by: SeongJae Park <sj@...nel.org>

I'll add 

Fixes: ab9bda001b681 ("mm/damon/core: introduce address range type damos filter")
Cc: <stable@...r.kernel.org>