linux-kernel - Re: [PATCH] mm/damon/core.c: avoid unintentional filtering out of schemes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231110182240.65426-1-sj@kernel.org>
Date:   Fri, 10 Nov 2023 18:22:40 +0000
From:   SeongJae Park <sj@...nel.org>
To:     Hyeongtak Ji <hyeongtak.ji@...il.com>
Cc:     sj@...nel.org, akpm@...ux-foundation.org, damon@...ts.linux.dev,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Hyeongtak Ji <hyeongtak.ji@...com>
Subject: Re: [PATCH] mm/damon/core.c: avoid unintentional filtering out of schemes

Hello Hyueongtak,

On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji <hyeongtak.ji@...il.com> wrote:

> The function '__damos_filter_out()' causes DAMON to always filter out
> schemes whose filter type is anon or memcg if its matching value is set
> to false.
> 
> This commit addresses the issue by ensuring that '__damos_filter_out()'
> no longer applies to filters whose type is 'anon' or 'memcg'.

Nice catch, thank you!

checkpatch.pl shows one warning, though:

    WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji <hyeongtak.ji@...il.com>' != 'Signed-off-by: Hyeongtak Ji <hyeongtak.ji@...com>'

> 
> Signed-off-by: Hyeongtak Ji <hyeongtak.ji@...com>

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

> ---
>  mm/damon/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index bcd2bd9d6c10..d5ef8945a343 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -920,7 +920,7 @@ static bool __damos_filter_out(struct damon_ctx *ctx, struct damon_target *t,
>  		matched = true;
>  		break;
>  	default:
> -		break;
> +		return false;


>  	}
>  
>  	return matched == filter->matching;
> -- 
> 2.7.4
> 
>