linux-kernel - Re: [PATCH] irqdesc: Fail check on early_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fs1bxe9h.wl-maz@kernel.org>
Date:   Sun, 12 Nov 2023 14:00:42 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Paran Lee <p4ranlee@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        shjy180909@...il.com, austindh.kim@...il.com
Subject: Re: [PATCH] irqdesc: Fail check on early_irq_init allocation.

On Sat, 11 Nov 2023 17:00:36 +0000,
Paran Lee <p4ranlee@...il.com> wrote:
> 
> When doing start_kernel(),
> On early_irq_init(), alloc_desc() or alloc_percpu()
> may be fails. So, Explicit fail check needed on dynamic allocation.

A failing allocation already results in a massive splat describing how
the allocation failed. Further use of the NULL pointer will also
result in a terminal oops, particularly if this happens this early in
the boot sequence.

So what do these BUG_ON() calls buy us?

	M.

-- 
Without deviation from the norm, progress is not possible.