linux-kernel - Re: [PATCH] irqdesc: Fail check on early_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f6e21c1-7340-ed40-f2a7-66c063b453cb@gmail.com>
Date:   Sun, 12 Nov 2023 23:19:28 +0900
From:   Paran Lee <p4ranlee@...il.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        shjy180909@...il.com, austindh.kim@...il.com
Subject: Re: [PATCH] irqdesc: Fail check on early_irq_init allocation.

On 2023-11-12 오후 11:00, Marc Zyngier wrote:

Thanks for the code review Marc!

I think function alloc_descs() in irqdesc.c has also alloc_desc() fail
handling, and there's kernel-wide code consistency checking for
allocation failures, and I thought it would be nice to mark it.
So that the code is aware of it.

Even if it panics with a null derefence reference.

> A failing allocation already results in a massive splat describing how
> the allocation failed. Further use of the NULL pointer will also
> result in a terminal oops, particularly if this happens this early in
> the boot sequence.
> 
> So what do these BUG_ON() calls buy us?
> 
> 	M.
> 

If anyone has any ideas on how to get a little fancier with the allocation,
I'll send a v2 patch in that direction.

BR
Paran Lee