[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231114024341.14524-1-heminhong@kylinos.cn>
Date: Tue, 14 Nov 2023 10:43:41 +0800
From: heminhong <heminhong@...inos.cn>
To: heminhong@...inos.cn
Cc: airlied@...il.com, animesh.manna@...el.com,
ankit.k.nautiyal@...el.com, daniel@...ll.ch,
dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
linux-kernel@...r.kernel.org, rodrigo.vivi@...el.com,
tvrtko.ursulin@...ux.intel.com, kernel test robot <lkp@...el.com>,
Ville Syrjälä
<ville.syrjala@...ux.intel.com>,
Uma Shankar <uma.shankar@...el.com>
Subject: [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()
Current, the dewake_scanline variable is defined as unsigned int,
an unsigned int variable that is always greater than or equal to 0.
when _intel_dsb_commit function is called by intel_dsb_commit function,
the dewake_scanline variable may have an int value.
So the dewake_scanline variable is necessary to defined as an int.
Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310052201.AnVbpgPr-lkp@intel.com/
Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc: Uma Shankar <uma.shankar@...el.com>
Signed-off-by: heminhong <heminhong@...inos.cn>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 78b6fe24dcd8..7fd6280c54a7 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
}
static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
- unsigned int dewake_scanline)
+ int dewake_scanline)
{
struct intel_crtc *crtc = dsb->crtc;
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
--
2.25.1
Powered by blists - more mailing lists