linux-kernel - Re: [PATCH v2] drm/i915: correct the input parameter on _intel_dsb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fs0o5v32.fsf@intel.com>
Date:   Wed, 29 Nov 2023 19:26:57 +0200
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     heminhong <heminhong@...inos.cn>, heminhong@...inos.cn
Cc:     airlied@...il.com, animesh.manna@...el.com,
        ankit.k.nautiyal@...el.com, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
        joonas.lahtinen@...ux.intel.com, linux-kernel@...r.kernel.org,
        rodrigo.vivi@...el.com, tvrtko.ursulin@...ux.intel.com,
        kernel test robot <lkp@...el.com>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        Uma Shankar <uma.shankar@...el.com>
Subject: Re: [PATCH v2] drm/i915: correct the input parameter on
 _intel_dsb_commit()

On Tue, 14 Nov 2023, heminhong <heminhong@...inos.cn> wrote:
> Current, the dewake_scanline variable is defined as unsigned int,
> an unsigned int variable that is always greater than or equal to 0.
> when _intel_dsb_commit function is called by intel_dsb_commit function,
> the dewake_scanline variable may have an int value.
> So the dewake_scanline variable is necessary to defined as an int.
>
> Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310052201.AnVbpgPr-lkp@intel.com/
> Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Cc: Uma Shankar <uma.shankar@...el.com>
>
> Signed-off-by: heminhong <heminhong@...inos.cn>

Pushed to drm-intel-next, thanks for the patch.

BR,
Jani.


> ---
>  drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 78b6fe24dcd8..7fd6280c54a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
>  }
>  
>  static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
> -			      unsigned int dewake_scanline)
> +			      int dewake_scanline)
>  {
>  	struct intel_crtc *crtc = dsb->crtc;
>  	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);

-- 
Jani Nikula, Intel