linux-kernel - Re: [PATCH 3/6] arm64: dts: qcom: sm8150: use 'gpios' suffix for PCI GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0109c9c9-3556-4b65-83b6-7d8b37b775a0@linaro.org>
Date:   Tue, 14 Nov 2023 16:30:08 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] arm64: dts: qcom: sm8150: use 'gpios' suffix for PCI
 GPIOs

On 13/11/2023 13:00, Konrad Dybcio wrote:
> On 11.11.2023 17:42, Krzysztof Kozlowski wrote:
>> Linux handles both versions, but bindings expect GPIO properties to
>> have 'gpios' suffix instead of 'gpio':
>>
>>   sa8155p-adp.dtb: pci@...0000: Unevaluated properties are not allowed ('perst-gpio' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
> What about the 'enable-gpio' right below it?

It needs to be documented first. enable-gpio/s seems to be missing from
the bindings and I did not have enough of time to investigate whether
this is correct in the first place.

That's why I thought about fixing only already accepted perst-gpios.

Best regards,
Krzysztof