linux-kernel - Re: [RFT PATCH 5/6] arm64: dts: qcom: sm6125: add interrupts to DWC3 USB controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pmkna4ckmm67kf6uuetwprbl4eiv4v7wluv4c7wosbsk557cnl@afkmfljmfloa>
Date:   Tue, 21 Nov 2023 22:26:13 +0100
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFT PATCH 5/6] arm64: dts: qcom: sm6125: add interrupts to DWC3
 USB controller

Maybe this should CC the people that have most recently worked on SM6125 and
related hardware?

On 2023-11-11 17:42:28, Krzysztof Kozlowski wrote:
> Add interrupts to SM6125 DWC3 USB controller, based on downstream/vendor
> code of Trinket DTSI from Xiaomi Laurel device, to fix dtbs_check
> warnings:
> 
>   sm6125-xiaomi-laurel-sprout.dtb: usb@...8800: 'interrupt-names' is a required property
>   sm6125-xiaomi-laurel-sprout.dtb: usb@...8800: 'oneOf' conditional failed, one must be fixed:
>     'interrupts' is a required property
>     'interrupts-extended' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Not tested on HW.

I have had an identical patch [1] on my tree for over one and a half years, but
recall not submitting it because of not being sure where to pull dm_hs_phy_irq /
dp_hs_phy_irq from.  I think you are right (in the dt-bindings fixup) that it is
not available on this platform.

Fixes: cff4bbaf2a2d ("arm64: dts: qcom: Add support for SM6125")
Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>

(and obviously tested)

[1]: https://github.com/somainline/linux/commit/b57f7fa80cb3f5cd2db3db2d79548cbf063056d9

> ---
>  arch/arm64/boot/dts/qcom/sm6125.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> index eb07eca3a48d..1dd3a4056e26 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> @@ -1185,6 +1185,10 @@ usb3: usb@...8800 {
>  					  <&gcc GCC_USB30_PRIM_MASTER_CLK>;
>  			assigned-clock-rates = <19200000>, <66666667>;
>  
> +			interrupts = <GIC_SPI 260 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "hs_phy_irq", "ss_phy_irq";
> +
>  			power-domains = <&gcc USB30_PRIM_GDSC>;
>  			qcom,select-utmi-as-pipe-clk;
>  			status = "disabled";
> -- 
> 2.34.1
>