linux-kernel - Re: [PATCH 01/20] mm/slab: remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55a589d7-edcc-6db4-759d-c928577cba8b@suse.cz>
Date:   Tue, 14 Nov 2023 21:11:46 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Kees Cook <keescook@...omium.org>
Cc:     David Rientjes <rientjes@...gle.com>,
        Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Hyeonggon Yoo <42.hyeyoo@...il.com>,
        Roman Gushchin <roman.gushchin@...ux.dev>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Alexander Potapenko <glider@...gle.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Marco Elver <elver@...gle.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        Muchun Song <muchun.song@...ux.dev>,
        kasan-dev@...glegroups.com, cgroups@...r.kernel.org
Subject: Re: [PATCH 01/20] mm/slab: remove CONFIG_SLAB from all Kconfig and
 Makefile

On 11/14/23 05:11, Kees Cook wrote:
> On Mon, Nov 13, 2023 at 08:13:42PM +0100, Vlastimil Babka wrote:
>> Remove CONFIG_SLAB, CONFIG_DEBUG_SLAB, CONFIG_SLAB_DEPRECATED and
>> everything in Kconfig files and mm/Makefile that depends on those. Since
>> SLUB is the only remaining allocator, remove the allocator choice, make
>> CONFIG_SLUB a "def_bool y" for now and remove all explicit dependencies
>> on SLUB as it's now always enabled.
>> 
>> Everything under #ifdef CONFIG_SLAB, and mm/slab.c is now dead code, all
>> code under #ifdef CONFIG_SLUB is now always compiled.
>> 
>> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
>> [...]
>> diff --git a/mm/Kconfig b/mm/Kconfig
>> index 89971a894b60..766aa8f8e553 100644
>> --- a/mm/Kconfig
>> +++ b/mm/Kconfig
>> @@ -228,47 +228,12 @@ config ZSMALLOC_CHAIN_SIZE
>>  
>>  menu "SLAB allocator options"
> 
> Should this be "Slab allocator options" ? (I've always understood
> "slab" to mean the general idea, and "SLAB" to mean the particular
> implementation.

Good point, will change

> Regardless:
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>

Thanks!