linux-kernel - Re: [PATCH] pinctrl: avoid reload of p state in interation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94de6d83-d181-4a04-875a-377fb5e10b25@quicinc.com>
Date:   Wed, 15 Nov 2023 08:56:35 +0800
From:   "Aiqun(Maria) Yu" <quic_aiquny@...cinc.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>, <stable@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: avoid reload of p state in interation

On 11/14/2023 9:21 PM, Linus Walleij wrote:
> Hi Maria,
> 
> thanks for your patch!
> 
> On Tue, Nov 14, 2023 at 9:54 AM Maria Yu <quic_aiquny@...cinc.com> wrote:
> 
>> When in the list_for_each_entry interation, reload of p->state->settings
>> with a local setting from old_state will makes the list interation in a
>> infite loop.
>>
>> Signed-off-by: Maria Yu <quic_aiquny@...cinc.com>
> 
> This makes sense in a way, since this is a compiler-dependent problem,
> can you state in the commit message which compiler and architecture
> you see this on?
I have a crash dump which caused by this issue which is using Clang 
10.0, arm64, Linux Version 4.19.
Thx for your suggestion, I will put this information in the commit message.
> 
> If it is a regression, should this also be queued for stable? (I guess so?)
This is a corner case which is very hard to reproduce in product, I 
suggest this fix to be queued for stable.
> 
> Yours,
> Linus Walleij

-- 
Thx and BRs,
Aiqun(Maria) Yu