linux-kernel - Re: [PATCH v2] crypto: x86/sm2 -add Zhaoxin SM2 algorithm implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <541fff8a-ad8f-43f5-9a44-c64302698029@intel.com>
Date:   Wed, 15 Nov 2023 11:21:41 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     kernel test robot <lkp@...el.com>,
        LeoLiu-oc <LeoLiu-oc@...oxin.com>, herbert@...dor.apana.org.au,
        davem@...emloft.net, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...or.com, seanjc@...gle.com, kim.phillips@....com,
        pbonzini@...hat.com, babu.moger@....com,
        jiaxi.chen@...ux.intel.com, jmattson@...gle.com,
        pawan.kumar.gupta@...ux.intel.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, CobeChen@...oxin.com,
        TonyWWang@...oxin.com, YunShen@...oxin.com, Leoliu@...oxin.com
Subject: Re: [PATCH v2] crypto: x86/sm2 -add Zhaoxin SM2 algorithm
 implementation


> vim +/asm +43 arch/x86/crypto/sm2-zhaoxin-gmi_glue.c
> 
>     35	
>     36	/* Zhaoxin sm2 verify function */
>     37	static inline int zhaoxin_gmi_sm2_verify(unsigned char *key, unsigned char *hash, unsigned char *sig,
>     38					unsigned char *scratch)
>     39	{
>     40		uint64_t cword, f_ok;
>     41		cword = (uint64_t)0x8;
>     42	
>   > 43		asm(".byte 0xf2, 0x0f, 0xa6, 0xc0"
>     44			:"=c"(f_ok), "+a"(hash), "+b"(key), "+d"(cword), "+S"(scratch), "+D"(sig));
>     45	
>     46		return f_ok;
>     47	}
>     48	

When you go fix your compile error, can you please look around the tree
and see what folks do for replacing .byte?  AS_SHA1_NI, for example.