linux-kernel - Re: [PATCH] iio: honeywell,mprls0025pa.yaml: fix function numbering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231116-grudge-hankering-b7a71d831b93@squawk>
Date:   Thu, 16 Nov 2023 18:34:16 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Andreas Klinger <ak@...klinger.de>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Petre Rodan <petre.rodan@...dimension.ro>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: honeywell,mprls0025pa.yaml: fix function numbering

On Thu, Nov 16, 2023 at 07:24:43PM +0100, Andreas Klinger wrote:
> Fix wrongly documented numbering of transfer functions.
> 
> Fixes: a765c985e696 ("dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor")
>

No blank line here.

> Suggested-by: Petre Rodan <petre.rodan@...dimension.ro>

This should be Reported-by.

> Signed-off-by: Andreas Klinger <ak@...klinger.de>
> ---
>  .../bindings/iio/pressure/honeywell,mprls0025pa.yaml        | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> index b31f8120f14e..61775eff1128 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> @@ -64,9 +64,9 @@ properties:
>      description: |
>        Transfer function which defines the range of valid values delivered by the
>        sensor.
> -      1 - A, 10% to 90% of 2^24 (1677722 .. 15099494)
> -      2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874)
> -      3 - C, 20% to 80% of 2^24 (3355443 .. 13421773)
> +      0 - A, 10% to 90% of 2^24 (1677722 .. 15099494)
> +      1 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874)
> +      2 - C, 20% to 80% of 2^24 (3355443 .. 13421773)

I don't understand. These are arbitrary numbers in a dt-binding, why
does zero or one indexing make any difference here?
Can't you just fix up the driver to correctly map the dt-binding to
whatever needs to be written to registers in the hardware?

Cheers,
Conor.

>      $ref: /schemas/types.yaml#/definitions/uint32
>  
>    vdd-supply:
> -- 
> 2.39.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)