linux-kernel - Re: Fwd: acp3x: Missing product ID for Thinkpad T14s Gen2 AMD Ryzen 7 PRO 5850U

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Nov 2023 19:36:00 +0100
From:   Oliver Sieber <ollisieber@...il.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Sound System <linux-sound@...r.kernel.org>,
        Linux ALSA Development <alsa-devel@...a-project.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: Fwd: acp3x: Missing product ID for Thinkpad T14s Gen2 AMD Ryzen 7
 PRO 5850U

Hi,

thanks for your fast answer. I added my proposed patch as attachment.

Please be aware that this is my first kernel patch.

Thanks a lot!

On 16.11.23 12:10, Bagas Sanjaya wrote:
> Hi,
>
> I notice a bug report on Bugzilla [1]. Quoting from it:
>
>> Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U.
>> My audio output is fine but my internal microphone cannot be found.
>>
>> Running `dmidecode` yields:
>>
>> Handle 0x000F, DMI type 1, 27 bytes
>> System Information
>> 	Manufacturer: LENOVO
>> 	Product Name: 20XGS1KT02
>> 	Version: ThinkPad T14s Gen 2a
>>
>> Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c?
>>
>>
>> It seems as there have been similar problems in the past, e.g. https://bugzilla.kernel.org/show_bug.cgi?id=216270.
> See Bugzilla for the full thread.
>
> ollisieber, can you send the quirk patch?
>
> Thanks.
>
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218148
>
View attachment "patch.diff" of type "text/x-patch" (529 bytes)