linux-kernel - fs/bcachefs/fsck.c:434:12: warning: stack frame size (1040) exceeds limit (1024) in 'reattach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202311200325.hyLM4Sx8-lkp@intel.com>
Date:   Mon, 20 Nov 2023 03:29:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kent Overstreet <kmo@...erainc.com>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: fs/bcachefs/fsck.c:434:12: warning: stack frame size (1040) exceeds
 limit (1024) in 'reattach_inode'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   037266a5f7239ead1530266f7d7af153d2a867fa
commit: a8b3a677e786fa869d220a6a78b5532a36dc2f4d bcachefs: Nocow support
date:   4 weeks ago
config: arm-randconfig-002-20231120 (https://download.01.org/0day-ci/archive/20231120/202311200325.hyLM4Sx8-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311200325.hyLM4Sx8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311200325.hyLM4Sx8-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from fs/bcachefs/fsck.c:5:
   In file included from fs/bcachefs/btree_update.h:5:
   fs/bcachefs/btree_iter.h:248:8: warning: duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier]
   static inline int btree_trans_restart_nounlock(struct btree_trans *trans, int err)
          ^
   include/linux/compiler_types.h:215:16: note: expanded from macro 'inline'
   #define inline inline __gnu_inline __inline_maybe_unused notrace
                  ^
   In file included from fs/bcachefs/fsck.c:5:
   In file included from fs/bcachefs/btree_update.h:5:
   fs/bcachefs/btree_iter.h:258:8: warning: duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier]
   static inline int btree_trans_restart(struct btree_trans *trans, int err)
          ^
   include/linux/compiler_types.h:215:16: note: expanded from macro 'inline'
   #define inline inline __gnu_inline __inline_maybe_unused notrace
                  ^
   fs/bcachefs/fsck.c:1001:12: warning: stack frame size (1104) exceeds limit (1024) in 'check_inodes' [-Wframe-larger-than]
   static int check_inodes(struct bch_fs *c, bool full)
              ^
   fs/bcachefs/fsck.c:1672:12: warning: stack frame size (1192) exceeds limit (1024) in 'check_dirents' [-Wframe-larger-than]
   static int check_dirents(struct bch_fs *c)
              ^
>> fs/bcachefs/fsck.c:434:12: warning: stack frame size (1040) exceeds limit (1024) in 'reattach_inode' [-Wframe-larger-than]
   static int reattach_inode(struct btree_trans *trans,
              ^
   5 warnings generated.


vim +/reattach_inode +434 fs/bcachefs/fsck.c

285b181ad460bb Kent Overstreet 2021-10-28  433  
285b181ad460bb Kent Overstreet 2021-10-28 @434  static int reattach_inode(struct btree_trans *trans,
285b181ad460bb Kent Overstreet 2021-10-28  435  			  struct bch_inode_unpacked *inode,
285b181ad460bb Kent Overstreet 2021-10-28  436  			  u32 inode_snapshot)
285b181ad460bb Kent Overstreet 2021-10-28  437  {
e68914ca849fa5 Kent Overstreet 2022-07-13  438  	int ret = commit_do(trans, NULL, NULL,
285b181ad460bb Kent Overstreet 2021-10-28  439  				  BTREE_INSERT_LAZY_RW|
285b181ad460bb Kent Overstreet 2021-10-28  440  				  BTREE_INSERT_NOFAIL,
285b181ad460bb Kent Overstreet 2021-10-28  441  			__reattach_inode(trans, inode, inode_snapshot));
58686a259ed28f Kent Overstreet 2021-04-19  442  	if (ret) {
d4bf5eecd78a90 Kent Overstreet 2022-07-18  443  		bch_err(trans->c, "error reattaching inode %llu: %s",
d4bf5eecd78a90 Kent Overstreet 2022-07-18  444  			inode->bi_inum, bch2_err_str(ret));
58686a259ed28f Kent Overstreet 2021-04-19  445  		return ret;
58686a259ed28f Kent Overstreet 2021-04-19  446  	}
58686a259ed28f Kent Overstreet 2021-04-19  447  
285b181ad460bb Kent Overstreet 2021-10-28  448  	return ret;
58686a259ed28f Kent Overstreet 2021-04-19  449  }
58686a259ed28f Kent Overstreet 2021-04-19  450  

:::::: The code at line 434 was first introduced by commit
:::::: 285b181ad460bb240041a9ca7935f9e884040405 bcachefs: Improve transaction restart handling in fsck code

:::::: TO: Kent Overstreet <kent.overstreet@...il.com>
:::::: CC: Kent Overstreet <kent.overstreet@...ux.dev>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki