linux-kernel - Re: [PATCH v2 5/5] misc: mlx5ctl: Add umem reg/unreg ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Nov 2023 03:29:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     oe-kbuild-all@...ts.linux.dev, Jason Gunthorpe <jgg@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>,
        Jiri Pirko <jiri@...dia.com>, Leonid Bloch <lbloch@...dia.com>,
        Itay Avraham <itayavr@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH v2 5/5] misc: mlx5ctl: Add umem reg/unreg ioctl

Hi Saeed,

kernel test robot noticed the following build warnings:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on rdma/for-next linus/master v6.7-rc1 next-20231117]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Saeed-Mahameed/misc-mlx5ctl-Add-mlx5ctl-misc-driver/20231119-215311
base:   char-misc/char-misc-testing
patch link:    https://lore.kernel.org/r/20231119092450.164996-6-saeed%40kernel.org
patch subject: [PATCH v2 5/5] misc: mlx5ctl: Add umem reg/unreg ioctl
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231120/202311200350.qRmXknpI-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311200350.qRmXknpI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311200350.qRmXknpI-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/posix_types.h:5,
                    from include/uapi/linux/types.h:14,
                    from include/linux/types.h:6,
                    from include/linux/kcsan-checks.h:14,
                    from include/asm-generic/barrier.h:17,
                    from arch/alpha/include/asm/barrier.h:21,
                    from arch/alpha/include/asm/rwonce.h:10,
                    from include/linux/compiler.h:251,
                    from include/linux/build_bug.h:5,
                    from include/linux/container_of.h:5,
                    from include/linux/list.h:5,
                    from include/linux/miscdevice.h:5,
                    from drivers/misc/mlx5ctl/main.c:4:
   drivers/misc/mlx5ctl/main.c: In function 'mlx5ctl_compat_ioctl':
   include/linux/stddef.h:8:14: error: called object is not a function or function pointer
       8 | #define NULL ((void *)0)
         |              ^
   include/linux/fs.h:1837:26: note: in expansion of macro 'NULL'
    1837 | #define compat_ptr_ioctl NULL
         |                          ^~~~
   drivers/misc/mlx5ctl/main.c:441:16: note: in expansion of macro 'compat_ptr_ioctl'
     441 |         return compat_ptr_ioctl(file, cmd, arg);
         |                ^~~~~~~~~~~~~~~~
>> drivers/misc/mlx5ctl/main.c:442:1: warning: control reaches end of non-void function [-Wreturn-type]
     442 | }
         | ^


vim +442 drivers/misc/mlx5ctl/main.c

   434	
   435	static long mlx5ctl_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
   436	{
   437		if (cmd == MLX5CTL_IOCTL_UMEM_UNREG) /* arg is a scalar */
   438			return mlx5ctl_ioctl(file, cmd, arg);
   439	
   440		/* arg is a pointer */
   441		return compat_ptr_ioctl(file, cmd, arg);
 > 442	}
   443	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki