linux-kernel - RE: [RFC PATCH] ASoC: simple-card: Use dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYCPR01MB109142FEC8F77CFFE3930456CD4B4A@TYCPR01MB10914.jpnprd01.prod.outlook.com>
Date:   Mon, 20 Nov 2023 23:04:52 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Daniel Baluta <daniel.baluta@...il.com>
CC:     Daniel Baluta <daniel.baluta@....nxp.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "iuliana.prodan@....com" <iuliana.prodan@....com>,
        "shengjiu.wang@....com" <shengjiu.wang@....com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Subject: RE: [RFC PATCH] ASoC: simple-card: Use dai_id from node description

Hi Daniel, Mark

> > > -     args.args_count = (of_graph_get_endpoint_count(node) > 1);
> > > +     args.args_count = (of_graph_get_endpoint_count(node) >= 1);
> >
> > If my understanding was correct, for example you want to use 2nd DAI
> > but your DT has only 1 port (thus, it is using reg property) ?
> 
> Yes.

But hmm... in your case, you need to setup 2ports, and use 2nd port
is assumed approach.
Why you don't setup full port ? Do you have some reason ??

I think almost all DTS are already using "reg" property, thus,
there is no problem if we remove non-reg-support,
but we don't know details.

Removing non-reg-support needs to update many codes. 
But your original patch is enough for 1st approach, and it is easy
to rewind the code if there was some issue.
I can create more detail cleanup code if there was no problem.

But then, I want to know it is necessary.
If there is good enough reasons why you don't setup full-port,
we can/need to remove non-reg-support. But if there is no good reason,
the things we need is not update code but you add full-port setup, I think.