linux-kernel - Re: [RFC PATCH] ASoC: simple-card: Use dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZD8zbgRzBrx+iHTbDqG5tOedNLyJByNNtSHTRtxFsgyGw@mail.gmail.com>
Date:   Tue, 21 Nov 2023 16:02:43 +0200
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     Daniel Baluta <daniel.baluta@....nxp.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "iuliana.prodan@....com" <iuliana.prodan@....com>,
        "shengjiu.wang@....com" <shengjiu.wang@....com>
Subject: Re: [RFC PATCH] ASoC: simple-card: Use dai_id from node description

On Tue, Nov 21, 2023 at 1:04 AM Kuninori Morimoto
<kuninori.morimoto.gx@...esas.com> wrote:
>
> Hi Daniel, Mark
>
> > > > -     args.args_count = (of_graph_get_endpoint_count(node) > 1);
> > > > +     args.args_count = (of_graph_get_endpoint_count(node) >= 1);
> > >
> > > If my understanding was correct, for example you want to use 2nd DAI
> > > but your DT has only 1 port (thus, it is using reg property) ?
> >
> > Yes.
>
> But hmm... in your case, you need to setup 2ports, and use 2nd port
> is assumed approach.
> Why you don't setup full port ? Do you have some reason ??

I'm not sure I understand what is a full port setup. But let me
describe my scenario so that we have a common ground.

I want to use audio-graph-card2 machine driver to setup Sound Open
Firrmware cards.

Here we start with a normal link with the following components:

Component 0 (DAI) : 3b6e8000.dsp (See sound/soc/sof/core.c: 280)
                                  -> for imx8m this has 3 statically
defined DAIs
See sound/soc/sof/imx/imx8m.c:

static struct snd_soc_dai_driver imx8m_dai[] = {
{     // DAI with index 0
»       .name = "sai1",
},
{      // DAI with index 1
»       .name = "sai3",
},
{ /   // DAI with index 2
»       .name = "micfil",
},
};

Component 1 (Codec): wm8960-hifi
                                    -> with 1 DAI

static struct snd_soc_dai_driver wm8960_dai = {
»       .name = "wm8960-hifi",
};

Now, I want to write a DTS description where my DAI link uses
Component 0 (CPU) (with its DAI index 1) connected with Component 1
(codec) (with its DAI index 0).

So, for this I use the following dts snippet:

sof-sound-wm8960 {
»       »       compatible = "audio-graph-card2";
»       »       links = <&cpu>;
}

dsp: dsp@...e8000 {
    cpu: port@1 {
»       »       reg = <1>;
»       »       cpu_ep: endpoint { remote-endpoint = <&codec_ep>; };
»       };
}

wm8960 {

»       port {
»       »       codec_ep: endpoint { remote-endpoint = <&cpu_ep>; };
»       };
}

So, property reg = <1> refferes to DAI with index 1 associated with
component DSP.