[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <875fbdff-cb89-4431-8e5a-51aefaff0be9@linaro.org>
Date: Mon, 20 Nov 2023 08:14:38 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Arnd Bergmann <arnd@...db.de>,
Bjorn Andersson <andersson@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Heiko Stuebner <heiko@...ech.de>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Michal Simek <michal.simek@....com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Nishanth Menon <nm@...com>, Olof Johansson <olof@...om.net>
Subject: Re: [PATCH] docs: dt-bindings: add DTS Coding Style document
On 16/11/2023 22:27, Conor Dooley wrote:
> On Thu, Nov 16, 2023 at 07:12:18PM +0100, Krzysztof Kozlowski wrote:
>> Document preferred coding style for Devicetree sources (DTS and DTSI),
>> to bring consistency among all (sub)architectures and ease in reviews.
>
> This is a good idea IMO, thanks for writing it.
>
> Should we also mention in this about the expected breakdown of things
> between $soc.dtsi and $soc-$board.dtsi? There's commonly confusion about
> things like oscillators and where they belong - particularly when the
> SoC mandates that these oscillators be of a single frequency.
> It may seem obvious to us what goes where, but certainly contributors
> frequently get this wrong.
Sure, I can add a chapter about DTS/DTSI split.
Best regards,
Krzysztof
Powered by blists - more mailing lists