linux-kernel - Re: [PATCH] docs: dt-bindings: add DTS Coding Style document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3a5f971-6fbb-4c23-a7a0-f1e85787d85c@linaro.org>
Date:   Mon, 20 Nov 2023 08:15:19 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Arnd Bergmann <arnd@...db.de>,
        Bjorn Andersson <andersson@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Heiko Stuebner <heiko@...ech.de>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Michal Simek <michal.simek@....com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Nishanth Menon <nm@...com>, Olof Johansson <olof@...om.net>
Subject: Re: [PATCH] docs: dt-bindings: add DTS Coding Style document

On 18/11/2023 00:53, Konrad Dybcio wrote:
> On 16.11.2023 19:12, Krzysztof Kozlowski wrote:
>> Document preferred coding style for Devicetree sources (DTS and DTSI),
>> to bring consistency among all (sub)architectures and ease in reviews.
>>
>> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Cc: Bjorn Andersson <andersson@...nel.org>
>> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
>> Cc: Heiko Stuebner <heiko@...ech.de>
>> Cc: Konrad Dybcio <konrad.dybcio@...aro.org>
>> Cc: Matthias Brugger <matthias.bgg@...il.com>
>> Cc: Michal Simek <michal.simek@....com>
>> Cc: Neil Armstrong <neil.armstrong@...aro.org>
>> Cc: Nishanth Menon <nm@...com>
>> Cc: Olof Johansson <olof@...om.net>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> ---
> [...]
> 
>> +Order of Nodes
>> +--------------
>> +
>> +1. Nodes within any bus, thus using unit addresses for children, shall be
>> +   ordered incrementally by unit address.
>> +
>> +2. Nodes without unit addresses should be ordered alpha-numerically.
> I largely agree with all this given our fight for some level of
> tidyness across linux-msm, but there's one specific case where I think
> it would make sense to break this ordering, and that's GPIO states:
> 
> 
> &pinctrl {
> 	xyz-active-state {
> 		pins ="gpio0";
> 		...
> 	};
> 
> 	abc-active-state {
> 		pins ="gpio1";
> 		...
> 	};
> 
> 	qwe-active-state {
> 		pins ="gpio2";
> 		...
> 	};
> };
> 
> looks so much more readable to me than

True. I'll mention exception for this and Renesas.

Best regards,
Krzysztof