linux-kernel - Re: [PATCH v3 6/6] tty: serial: amba-pl011: factor QDF2400 SoC erratum 44 out of probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CX3OTU62O1C4.1XI8WONTYYFU1@tleb-bootlin-xps13-01>
Date:   Mon, 20 Nov 2023 14:53:19 +0100
From:   Théo Lebrun <theo.lebrun@...tlin.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     "Russell King" <linux@...linux.org.uk>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Jiri Slaby" <jirislaby@...nel.org>,
        "LKML" <linux-kernel@...r.kernel.org>,
        "linux-serial" <linux-serial@...r.kernel.org>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        Grégory Clement <gregory.clement@...tlin.com>,
        "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
        "Thomas Petazzoni" <thomas.petazzoni@...tlin.com>,
        "Vladimir Kondratiev" <vladimir.kondratiev@...ileye.com>,
        "Tawfik Bayouk" <tawfik.bayouk@...ileye.com>
Subject: Re: [PATCH v3 6/6] tty: serial: amba-pl011: factor QDF2400 SoC
 erratum 44 out of probe

Hello,

On Mon Nov 20, 2023 at 10:55 AM CET, Ilpo Järvinen wrote:
> On Mon, 20 Nov 2023, Théo Lebrun wrote:
>
> > On this platform, different vendor data is used. That requires a
> > compile-time check as we access (1) a global boolean & (2) our local
> > vendor data. Both symbols are accessible only when
> > CONFIG_ACPI_SPCR_TABLE is enabled.
> > 
> > Factor the vendor data overriding to a separate function that is empty
> > when CONFIG_ACPI_SPCR_TABLE is not defined.
> > 
> > Suggested-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> > Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
> > ---
> >  drivers/tty/serial/amba-pl011.c | 25 ++++++++++++++++++-------
> >  1 file changed, 18 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> > index 4185d6fd243b..e08a32eb0ed1 100644
> > --- a/drivers/tty/serial/amba-pl011.c
> > +++ b/drivers/tty/serial/amba-pl011.c
> > @@ -2874,6 +2874,22 @@ static int pl011_resume(struct device *dev)
> >  
> >  static SIMPLE_DEV_PM_OPS(pl011_dev_pm_ops, pl011_suspend, pl011_resume);
> >  
> > +#ifdef CONFIG_ACPI_SPCR_TABLE
> > +static void qpdf2400_erratum44_workaround(struct device *dev,
> > +					  struct uart_amba_port *uap)
> > +{
> > +	if (qdf2400_e44_present)
>
> This should be !qdf2400_e44_present.

Completely right! I reversed the if-logic to see how it looked & I
forgot negating the condition when going back to the current shape.
I've got the fix ready for a v4. You've got some good eyes, thanks.

I'll wait a bit to see if there are any other review & avoid spamming
the maintainers.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com