linux-kernel - Re: Fwd: sysfs: cannot create duplicate filename .../system76_acpi::kbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sf50pm34.wl-tiwai@suse.de>
Date:   Mon, 20 Nov 2023 14:53:51 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Jean-Jacques Hiblot <jjhiblot@...phandler.com>
Cc:     Bagas Sanjaya <bagasdotme@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Regressions <regressions@...ts.linux.dev>,
        Linux LEDs <linux-leds@...r.kernel.org>,
        Tim Crawford <tcrawford@...tem76.com>,
        Jeremy Soller <jeremy@...tem76.com>,
        System76 Product Development <productdev@...tem76.com>,
        Lee Jones <lee@...nel.org>, Pavel Machek <pavel@....cz>,
        Johannes Penßel 
        <johannes.penssel@...il.com>
Subject: Re: Fwd: sysfs: cannot create duplicate filename .../system76_acpi::kbd_backlight/color

On Mon, 06 Nov 2023 14:19:08 +0100,
Bagas Sanjaya wrote:
> 
> On Sat, Nov 04, 2023 at 01:01:56PM +0100, Jean-Jacques Hiblot wrote:
> > 
> > 
> > On 29/10/2023 02:48, Bagas Sanjaya wrote:
> > > On Thu, Oct 26, 2023 at 02:55:06PM +0700, Bagas Sanjaya wrote:
> > > > The culprit seems to be commit c7d80059b086c4986cd994a1973ec7a5d75f8eea, which introduces a new 'color' attribute for led sysfs class devices. The problem is that the system76-acpi platform driver tries to create the exact same sysfs attribute itself for the system76_acpi::kbd_backlight device, leading to the conflict. For testing purposes, I've just rebuilt the kernel with the system76-apci color attribute renamed to kb_color, and that fixes the issue.
> > > 
> > > Jean-Jacques Hiblot, would you like to take a look on this regression,
> > > since you authored the culprit?
> > Hi,
> > 
> > The offending commit stores the color in struct led_classdev and exposes it
> > via sysfs. It was part of a series that create a RGB leds from multiple
> > single-color LEDs. for this series, we need the color information but we
> > don't really need to expose it it via sysfs. In order to fix the issue, we
> > can remove the 'color' attribute from the sysfs.
> > 
> 
> OK, see you in the patch!

Is there a patch available?

This bug hits for a few Logitech keyboard models, too, and it makes
6.6 kernel unsable for them, as hid-lg-g15 driver probe fails due to
this bug:
  https://bugzilla.kernel.org/show_bug.cgi?id=218155

We need a quick fix for 6.6.x.


Thanks!

Takashi