linux-kernel - Re: [PATCH v6 10/13] x86/bugs: Rename RETHUNK to MITIGATION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da12ea3e-8fef-49d4-aea1-40a46a5ae056@citrix.com>
Date:   Tue, 21 Nov 2023 21:39:47 +0000
From:   Andrew Cooper <andrew.cooper3@...rix.com>
To:     Breno Leitao <leitao@...ian.org>, jpoimboe@...nel.org,
        mingo@...hat.com, tglx@...utronix.de, bp@...en8.de,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
        Jason Baron <jbaron@...mai.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ard Biesheuvel <ardb@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>
Cc:     leit@...a.com, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...nel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Sven Joachim <svenjoac@....de>, Ian Kent <raven@...maw.net>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Kees Cook <keescook@...omium.org>,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        Kim Phillips <kim.phillips@....com>,
        Juergen Gross <jgross@...e.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Jinghao Jia <jinghao@...ux.ibm.com>,
        Vincent Whitchurch <vincent.whitchurch@...s.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH v6 10/13] x86/bugs: Rename RETHUNK to MITIGATION_RETHUNK

On 21/11/2023 4:07 pm, Breno Leitao wrote:
> CPU mitigations config entries are inconsistent, and names are hard to
> related. There are concrete benefits for both users and developers of
> having all the mitigation config options living in the same config
> namespace.
>
> The mitigation options should have consistency and start with
> MITIGATION.
>
> Rename the Kconfig entry from RETHUNK to MITIGATION_RETHUNK.
>
> Suggested-by: Josh Poimboeuf <jpoimboe@...nel.org>
> Signed-off-by: Breno Leitao <leitao@...ian.org>

(I'm CC'd on only this single patch so I can't see what's going on, but)

Really?  Rethunk[sic] isn't a mitigation.  It's just a compiler
transformation for return instructions upon which various mitigations
depend.

~Andrew